Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #134 #136

Merged
merged 2 commits into from Mar 18, 2022
Merged

Fix #134 #136

merged 2 commits into from Mar 18, 2022

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/smrnaseq/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This only adds a simple bugfix for cases where a sample is entirely zero for all genes that are left after filtering out for zero expression genes in the matrix. Fixes #134 - tests with a broken case are running 馃憤馃徎

@apeltzer apeltzer requested a review from lpantano March 17, 2022 17:32
@apeltzer
Copy link
Member Author

Confirmed and tested that this indeed fixes the issue 馃憤馃徎

bin/edgeR_miRBase.r Outdated Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Mar 18, 2022

Confirmed and tested that this indeed fixes the issue 馃憤馃徎

I'll trust you there ;).

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants