Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to use a genome not in igenomes #63

Closed
wants to merge 3 commits into from
Closed

Allowing to use a genome not in igenomes #63

wants to merge 3 commits into from

Conversation

sdjebali
Copy link
Contributor

@sdjebali sdjebali commented Jan 11, 2021

Description of changes

  • correct gunzip action and variable assignment of hairpin and mature fasta files in bowtie_indices step
  • remove file 'genome.fa' into fasta from the bowtie_indices outputs
  • replace fasta by reference_genome in file refgenome from fasta of mirdeep2 inputs
  • replace Y nt by N in hairpin.fa

Adding tests

Tested with the following commands:

module load bioinfo/Nextflow-v20.10.0
module load system/singularity-3.6.4
export SINGULARITY_PULLFOLDER=/work/project/fragencode/workspace/geneswitch/code/containers/singularity
nextflow run <codedir>/smrnaseq \
  --input <datadir>/sus_scrofa/*.fastq.gz \
  --fasta <datadir>/sus_scrofa/Sscrofa11.1.101/sus_scrofa_nowhitespace.fa \
  --mirtrace_species ssc \
  -profile singularity \
  --protocol nextflex \
  --outdir <outdir> \
  --max_memory '16.GB' \
  --max_cpus 2 \
  --email <myemail> \
  --skip_mirdeep \
  -resume \
  > nextflow.out 2> nextflow.err

(edited by @ewels to split arguments onto their own lines)

Minimal inputs for this pipeline can be found at http://genoweb.toulouse.inra.fr/~sdjebali/nf-core/smrnaseq/

However I am still getting an error:

No such variable: reference_genome
 -- Check script '/work2/project/fragencode/workspace/sdjebali/geneswitch/pipelines/srnaseq/smrnaseq/main.nf' at line: 830 or see '.nextflow.log' file for more details

Ensure the test suite passes

I have tried it
but
nextflow run . -profile test,docker
returns
Cannot enable more than one container engine -- Choose either one of: docker, singularity

Make sure your code lints

do not know where to find nf-core executable sorry

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/smrnaseq/tree/master/.github/CONTRIBUTING.md

main.nf Outdated Show resolved Hide resolved
Copy link
Contributor

@lpantano lpantano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put some changes to make this work with the skip_mirdeep option. It is working for me.

fi
if [ \${HAIRPIN: -3} == ".gz" ]; then
gunzip -f \$HAIRPIN
HAIRPIN=\${HAIRPIN: -3}
HAIRPIN=\${HAIRPIN%%.gz}
fi

# Remove any special base characters from reference genome FASTA file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line below should be:
sed '/^[^>]/s/[^ATGCatgc]/N/g' $refgenome > genome.fa

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and update below to bowtie-build genome.fa genome

main.nf Outdated Show resolved Hide resolved
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple of these "suggested changes" so that they can be applied easily. Can't do all of them sadly.

main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
@lpantano
Copy link
Contributor

this PR was addressed in #65, should we close this? or there is another feature/bug here? Thanks!

@sdjebali
Copy link
Contributor Author

sdjebali commented Mar 1, 2021 via email

@ewels ewels closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants