Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated mirtrace in software versions #82

Merged
merged 5 commits into from May 11, 2021
Merged

updated mirtrace in software versions #82

merged 5 commits into from May 11, 2021

Conversation

KevinMenden
Copy link
Contributor

Updated the mirtrace call in get_software_versions to not allocate half of the available memory.

ewels
ewels requested changes May 10, 2021
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be done for the main mirtrace process as well?

main.nf Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
KevinMenden and others added 2 commits May 10, 2021 09:38
@KevinMenden @ewels
Update main.nf
a62bd5d 
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
@KevinMenden @ewels
Update main.nf
af5718d 
Co-authored-by: Phil Ewels <phil.ewels@scilifelab.se>
@KevinMenden
Copy link
Contributor Author

Yes, I already did that - although I will now apply your suggestions there too :-)

@KevinMenden KevinMenden linked an issue May 10, 2021 that may be closed by this pull request
mirtrace tries to allocate half of the installed RAM #68
Closed
ggabernet
ggabernet approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

ewels
ewels approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KevinMenden KevinMenden merged commit 451be57 into nf-core:dev May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

@ggabernet ggabernet ggabernet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mirtrace tries to allocate half of the installed RAM
3 participants
@KevinMenden @ewels @ggabernet