Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up parameters #86

Merged
merged 3 commits into from
May 12, 2021
Merged

cleaned up parameters #86

merged 3 commits into from
May 12, 2021

Conversation

KevinMenden
Copy link
Contributor

  • added missing parameters ("unexpected") to nextflow.config and nextflow_schema.json
  • removed the logging about single_end as that's the only supported configuration anway

@KevinMenden KevinMenden mentioned this pull request May 12, 2021
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ewels
Copy link
Member

ewels commented May 12, 2021

Something funky going on with the schema here..

@KevinMenden
Copy link
Contributor Author

Yes already fixed it, just had to remove the default value for bt_indices
Otherwise the validation of default parameters gets angry

@KevinMenden
Copy link
Contributor Author

I'll update a few more versions before merging

@KevinMenden
Copy link
Contributor Author

On second thought those are mostly r package which I don't want to touch ... let's leave it at this for now

@KevinMenden KevinMenden merged commit f7c91d2 into nf-core:dev May 12, 2021
@@ -130,7 +130,7 @@
},
"bt_indices": {
"type": "array",
"default": "null"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinMenden did the nf-core schema build command put this here?

Need to fix that behaviour if so..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants