Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module vcf2maf: Added working VEP cache with no annotations #563

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

adamrtalbot
Copy link

@adamrtalbot adamrtalbot commented Jun 20, 2022

Adds working minimal VEP cache for using with vcf2maf module (and possibly VEP module in future).

By including these two files, VEP runs correctly but doesn't annotate. I've reduced it to just chr22 to match the available test VCF and FASTA.

@FriederikeHanssen
Copy link

Can you add it to the two Readmes:

I guess no way of somehow basing this on the existing fasta?

@adamrtalbot
Copy link
Author

I guess no way of somehow basing this on the existing fasta?

It's based on the FASTA data/genomics/homo_sapiens/genome/genome.fasta. I used this one because it supports the available uncompressed VCF file data/genomics/homo_sapiens/illumina/gvcf/test.genome.vcf.

@FriederikeHanssen
Copy link

perfect 🎉

@adamrtalbot
Copy link
Author

@FriederikeHanssen both README updated.

@adamrtalbot
Copy link
Author

Apologies, my markdown formatter appears to have messed with the files.

@FriederikeHanssen FriederikeHanssen merged commit f4befe0 into nf-core:modules Jun 20, 2022
@FriederikeHanssen
Copy link

woops merged already 🤠 it'll be fine

@adamrtalbot adamrtalbot deleted the vcf2maf branch June 20, 2022 11:12
adamrtalbot pushed a commit to adamrtalbot/modules that referenced this pull request Jun 20, 2022
Additions:
 - vcf2maf module created
 - If VEP is present in PATH, it is added to command
 - If VEP is missing, it is ignored (recommended to skip with --inhibit-vep)
 - VEP version automatically added to versions.yml
 - Uses VEP cache during testing which is added to test-datasets in nf-core/test-datasets#563
 - Default Docker image includes VEP and vcf2maf
 - Test includes without VEP.

Relates to nf-core#490
FriederikeHanssen pushed a commit to nf-core/modules that referenced this pull request Jun 20, 2022
vcf2maf module created

Additions:
 - vcf2maf module created
 - If VEP is present in PATH, it is added to command
 - If VEP is missing, it is ignored (recommended to skip with --inhibit-vep)
 - VEP version automatically added to versions.yml
 - Uses VEP cache during testing which is added to test-datasets in nf-core/test-datasets#563
 - Default Docker image includes VEP and vcf2maf
 - Test includes without VEP.

Relates to #490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants