Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cycif tonsil image and move spatialomics to imaging #821

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

jmuhlich
Copy link
Member

This adds a new cyclic immunofluorescence image dataset into a new imaging directory and renames/reorganizes the existing spatialomics directory into imaging. This renaming was done with the approval of @FloWuenne who originally added the spatialomics data. We decided the data there was all applicable to image processing in general and thus "imaging" would be a better name. READMEs have been added to the leaf directories with more detailed info on each file collection.

Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also open a quick PR that updates the tests/config/test_data.config file in the modules repo so we don't break any tests for modules dependent on the spatialomics data? :)

(Also please wait for a second approval since this is a new category 😁)

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@adamjtaylor adamjtaylor linked an issue Mar 28, 2023 that may be closed by this pull request
@adamjtaylor adamjtaylor merged commit aab1eca into nf-core:modules Mar 28, 2023
@jmuhlich jmuhlich deleted the modules-imaging branch July 6, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename spatialomics to imaging for modules branch
4 participants