Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nf-core modules create creates wrong process label when subtool is given #1011

Closed
KevinMenden opened this issue Apr 14, 2021 · 1 comment · Fixed by #1028
Closed

nf-core modules create creates wrong process label when subtool is given #1011

KevinMenden opened this issue Apr 14, 2021 · 1 comment · Fixed by #1028
Labels
bug Something isn't working

Comments

@KevinMenden
Copy link
Contributor

When using nf-core modules create tool/subtool, the main.nf file will have a process name called TOOL/SUBTOOL which should be TOOL_SUBTOOL.

The reason for that is that we don't set the self.subtool variable anymore (it's always None).
So to solve this we should just check, in the init function of the ModuleCreate class, whether the tool has a subtool and then set self.subtool to true/false accordingly.
@KevinMenden KevinMenden added the bug Something isn't working label Apr 14, 2021
KevinMenden added a commit to KevinMenden/tools that referenced this issue Apr 16, 2021
@KevinMenden
fixed bug nf-core#1011
790e980
@KevinMenden KevinMenden mentioned this issue Apr 16, 2021
Merged
4 tasks
@KevinMenden KevinMenden linked a pull request Apr 16, 2021 that will close this issue
fixed bug #1011 #1028
Merged
4 tasks
@KevinMenden
Copy link
Contributor Author

The underlying problem was actually different. Anyway it's fixed in #1028

KevinMenden added a commit that referenced this issue Apr 16, 2021
@KevinMenden
Merge pull request #1028 from KevinMenden/modules-create-name-fix
bf77ba6 
fixed bug #1011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed bug #1011 KevinMenden/tools
1 participant
@KevinMenden