Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug #1011 #1028

Merged
merged 7 commits into from
Apr 16, 2021
Merged

Conversation

KevinMenden
Copy link
Contributor

Fixes #1011

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #1028 (d15d4e6) into dev (bdd32f9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d15d4e6 differs from pull request most recent head b9336f7. Consider uploading reports for the commit b9336f7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1028   +/-   ##
=======================================
  Coverage   69.41%   69.42%           
=======================================
  Files          34       34           
  Lines        4283     4284    +1     
=======================================
+ Hits         2973     2974    +1     
  Misses       1310     1310           
Impacted Files Coverage Δ
nf_core/modules/create.py 59.78% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd32f9...b9336f7. Read the comment docs.

@drpatelh
Copy link
Member

Thanks! When I created the ucsc/bedclip module yesterday I had to change from / to _ in multiple places. Be great if you can create a dummy module and check this?

@KevinMenden
Copy link
Contributor Author

Ah thanks! Didn't look at the test main.nf fixed it there as well.
That should be all I think ...

@drpatelh
Copy link
Member

./software/bwa/test/main.nf
./software/bwa/test/meta.yml
./tests/software/bwa/test/main.nf
./tests/software/bwa/test/test.yml

Ok. Just double-checked. All of these files need to be changed 👀

Also, need to add a newline at the end of functions.nf in the module template because it is failing the EClint.

@drpatelh
Copy link
Member

Also, need to add a newline at the end of functions.nf in the module template because it is failing the EClint.

Be great if you can fix this too :)

@KevinMenden KevinMenden merged commit bf77ba6 into nf-core:dev Apr 16, 2021
@KevinMenden KevinMenden deleted the modules-create-name-fix branch April 16, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-core modules create creates wrong process label when subtool is given
2 participants