Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link in nf-core modules info broken #1736

Closed
ErikDanielsson opened this issue Aug 5, 2022 · 0 comments · Fixed by #1745
Closed

Link in nf-core modules info broken #1736

ErikDanielsson opened this issue Aug 5, 2022 · 0 comments · Fixed by #1745
Assignees
@mirpedrol
Labels
bug Something isn't working
Milestone
2.5

Comments

@ErikDanielsson
Copy link
Contributor

ErikDanielsson commented Aug 5, 2022 •
edited
Loading

Description of the bug

The link created by nf-core modules info is broken since the move from the github api. The link is set on https://github.com/nf-core/tools/blob/dev/nf_core/modules/info.py#L164-L168, but the self.remote_location is either a https or ssh address so the link is broken.

Command used and terminal output

$ nf-core modules info

System information

nf-core/tools @2.5dev
@ErikDanielsson ErikDanielsson added the bug Something isn't working label Aug 5, 2022
@ErikDanielsson ErikDanielsson added this to the 2.5 milestone Aug 5, 2022
@mirpedrol mirpedrol self-assigned this Aug 8, 2022
@mirpedrol mirpedrol mentioned this issue Aug 8, 2022
Merged
4 tasks
@ewels ewels closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirpedrol mirpedrol

Labels
bug Something isn't working
Projects
None yet
Milestone
2.5
Development

Successfully merging a pull request may close this issue.

Fix broken link in nf-core modules info mirpedrol/tools
3 participants
@ewels @mirpedrol @ErikDanielsson