Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in nf-core modules info #1745

Merged
merged 7 commits into from
Aug 18, 2022
Merged

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Aug 8, 2022

Close #1736

Don't add the prefix https://github.com to the link created by nf-core modules info. Make the link clickable if self.remote_location starts by 'http'

The command was also failing when there wasn't any module installed from a remote repository. I added the attribute self.local to ensure that we only try to obtain information from a local module if it is locally installed.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @mirpedrol,

It looks like this pull-request is has been made against the mirpedrol/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the mirpedrol/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@mirpedrol mirpedrol changed the base branch from master to dev August 8, 2022 07:55
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1745 (c3b32d5) into dev (ccad6e6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1745      +/-   ##
==========================================
- Coverage   68.45%   68.44%   -0.01%     
==========================================
  Files          59       59              
  Lines        7136     7137       +1     
==========================================
  Hits         4885     4885              
- Misses       2251     2252       +1     
Impacted Files Coverage Δ
nf_core/modules/info.py 17.03% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol marked this pull request as ready for review August 8, 2022 08:11
nf_core/modules/info.py Outdated Show resolved Hide resolved
@ewels
Copy link
Member

ewels commented Aug 18, 2022

Haven't tested it, but reading the code looks good 🚀

@ewels ewels merged commit d30d1c0 into nf-core:dev Aug 18, 2022
@mirpedrol mirpedrol deleted the moduleinfo branch August 18, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link in nf-core modules info broken
3 participants