Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema builder to use JSON draft 2020-12 #2784

Open
Tracked by #2429
mirpedrol opened this issue Feb 20, 2024 · 2 comments
Open
Tracked by #2429

Update schema builder to use JSON draft 2020-12 #2784

mirpedrol opened this issue Feb 20, 2024 · 2 comments
Labels

Comments

@mirpedrol
Copy link
Member

Description of feature

nf-validation v2.0 uses the latest JSON Schema draft 2020-12

Prior to re-writing the nf-core schema builder, we should update the basis to make it compatible with the new version of nf-validation. That is:

  • Changing the schema specification form http://json-schema.org/draft-07/schema to https://json-schema.org/draft/2020-12/schema
  • Changing the keyword definitions to defs

nf-validation migration docs

@ewels
Copy link
Member

ewels commented Feb 20, 2024

Should be able to do this with a quick string regex on the returned JSON from the web builder, before saving locally.

@alvaromartmart
Copy link

Isn't $defs the correct keyword in the new schema and not defs? https://json-schema.org/draft/2019-09/release-notes#keyword-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants