Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema - don't make default null for null values. #1077

Merged
merged 1 commit into from
May 12, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented May 12, 2021

Closes #1074

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from KevinMenden May 12, 2021 10:18
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #1077 (47c7a99) into dev (344ff29) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1077      +/-   ##
==========================================
- Coverage   72.21%   72.20%   -0.01%     
==========================================
  Files          36       36              
  Lines        4545     4547       +2     
==========================================
+ Hits         3282     3283       +1     
- Misses       1263     1264       +1     
Impacted Files Coverage Δ
nf_core/schema.py 85.35% <66.66%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9263c...47c7a99. Read the comment docs.

Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that was fast 👍

@ewels ewels merged commit 7ba366d into nf-core:dev May 12, 2021
@ewels ewels deleted the schema-null-default branch May 12, 2021 11:09
@ewels
Copy link
Member Author

ewels commented May 12, 2021

Yeah, figured that I should just get on and fix it while I was thinking about it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants