Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update subworkflows install so it installs also imported modules and subworkflows #1904

Merged
merged 4 commits into from
Oct 10, 2022

Conversation

mirpedrol
Copy link
Member

The command nf-core subworkflows install installs also the modules and subworkflows imported in the subworkflow.

To deal with already installed modules, I had to add a question asking if the modules should be re-installed with --force. Because subworkflows will need to work with the last version of the modules, the modules must be re-installed (aka. updated), otherwise the installation fails.

🧠 what will happen when installing an older version of a subworkflow?

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@yuukiiwa yuukiiwa self-requested a review October 10, 2022 13:54
Copy link

@yuukiiwa yuukiiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mirpedrol!! Looks good to me!

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1904 (1feb390) into dev (8aeb965) will decrease coverage by 0.26%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##              dev    #1904      +/-   ##
==========================================
- Coverage   60.30%   60.04%   -0.27%     
==========================================
  Files          37       37              
  Lines        4608     4635      +27     
==========================================
+ Hits         2779     2783       +4     
- Misses       1829     1852      +23     
Impacted Files Coverage Δ
nf_core/subworkflows/install.py 14.39% <12.50%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol merged commit 5bdd161 into nf-core:dev Oct 10, 2022
@mirpedrol mirpedrol deleted the install branch October 10, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants