Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate work dir cleanup on successful completion #2163

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Activate work dir cleanup on successful completion #2163

merged 2 commits into from
Jan 20, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 20, 2023

To help reduce AWS S3 maintainence and costs

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@jfy133 jfy133 changed the base branch from master to dev January 20, 2023 12:01
@github-actions

This comment was marked as resolved.

Sign in to view
FriederikeHanssen
FriederikeHanssen approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea, but maybe a few people could add there opinions here

mirpedrol
mirpedrol approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good solution 👍

@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #2163 (67c8aa9) into dev (681ccf3) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2163      +/-   ##
==========================================
+ Coverage   71.44%   71.49%   +0.04%     
==========================================
  Files          77       77              
  Lines        8378     8378              
==========================================
+ Hits         5986     5990       +4     
+ Misses       2392     2388       -4
Impacted Files Coverage Δ
nf_core/utils.py 82.38% <0.00%> (+0.18%) ⬆️
nf_core/modules/test_yml_builder.py 52.00% <0.00%> (+1.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ewels
ewels approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133 jfy133 merged commit 546548a into dev Jan 20, 2023
@jfy133 jfy133 deleted the auto-cleanup-fulltest branch January 20, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jfy133 @ewels @mirpedrol @FriederikeHanssen