Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff - Replace Black, isort and pyupgrade #2620

Merged
merged 22 commits into from Jan 4, 2024

Conversation

mirpedrol
Copy link
Member

Replace PR #2174
Close #2533

Implement Ruff linter. In replacement of Black, isort and pyupgrade. It also includes Flake8.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (7831f7a) 75.19% compared to head (eb4b775) 75.00%.
Report is 1 commits behind head on dev.

Files Patch % Lines
nf_core/sync.py 50.00% 11 Missing ⚠️
nf_core/download.py 50.00% 9 Missing ⚠️
nf_core/__main__.py 0.00% 8 Missing ⚠️
nf_core/modules/bump_versions.py 33.33% 8 Missing ⚠️
nf_core/modules/lint/main_nf.py 87.75% 6 Missing ⚠️
nf_core/modules/lint/__init__.py 33.33% 2 Missing ⚠️
nf_core/subworkflows/lint/__init__.py 33.33% 2 Missing ⚠️
nf_core/components/info.py 50.00% 1 Missing ⚠️
nf_core/components/lint/__init__.py 50.00% 1 Missing ⚠️
nf_core/launch.py 66.66% 1 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2620      +/-   ##
==========================================
- Coverage   75.19%   75.00%   -0.19%     
==========================================
  Files          85       85              
  Lines        9384     9363      -21     
==========================================
- Hits         7056     7023      -33     
- Misses       2328     2340      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.gitpod.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
nf_core/params_file.py Show resolved Hide resolved
nf_core/params_file.py Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/create-lint-wf.yml Outdated Show resolved Hide resolved
.github/workflows/lint-code.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
nf_core/pipeline-template/pyproject.toml Show resolved Hide resolved
nf_core/pipeline-template/pyproject.toml Outdated Show resolved Hide resolved
nf_core/pipeline-template/pyproject.toml Outdated Show resolved Hide resolved
mirpedrol and others added 6 commits January 4, 2024 09:50
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol mirpedrol merged commit d91a3bf into nf-core:dev Jan 4, 2024
19 of 20 checks passed
@mirpedrol mirpedrol deleted the add-ruff branch January 4, 2024 10:24
@mirpedrol mirpedrol mentioned this pull request Jan 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants