Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run pyupgrade for python 3.8 compatibility #2623

Closed
wants to merge 1 commit into from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 2, 2024

Manually checked changes and look good to me (wast majority is just removing the now default "r" from open() statements)

@mashehu mashehu requested a review from mirpedrol January 2, 2024 09:48
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (7831f7a) 75.19% compared to head (74d22ab) 75.04%.
Report is 1 commits behind head on dev.

Files Patch % Lines
nf_core/modules/bump_versions.py 25.00% 3 Missing ⚠️
nf_core/components/info.py 50.00% 1 Missing ⚠️
nf_core/lint/files_unchanged.py 66.66% 1 Missing ⚠️
nf_core/modules/lint/main_nf.py 66.66% 1 Missing ⚠️
nf_core/modules/lint/module_patch.py 66.66% 1 Missing ⚠️
nf_core/modules/lint/module_tests.py 75.00% 1 Missing ⚠️
nf_core/subworkflows/lint/subworkflow_tests.py 75.00% 1 Missing ⚠️
nf_core/sync.py 0.00% 1 Missing ⚠️
nf_core/utils.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2623      +/-   ##
==========================================
- Coverage   75.19%   75.04%   -0.15%     
==========================================
  Files          85       85              
  Lines        9384     9389       +5     
==========================================
- Hits         7056     7046      -10     
- Misses       2328     2343      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu
Copy link
Contributor Author

mashehu commented Jan 4, 2024

superseded by #2620

@mashehu mashehu closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant