Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nf-core download: Ability to add custom tags to revisions in downloaded pipelines #2938

Merged
merged 16 commits into from
May 7, 2024
Merged

nf-core download: Ability to add custom tags to revisions in downloaded pipelines #2938

merged 16 commits into from
May 7, 2024

Commits on May 6, 2024

  1. Update Docstring of DownloadWorkflow class.

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6ab6c8d View commit details
    Browse the repository at this point in the history

  2. Include the '--additional_tags' argument in the CLI for 'nf-core down… 

    …load'
    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d2f8525 View commit details
    Browse the repository at this point in the history

  3. Started with additional_tags handling in the level of the DownloadWor… 

    …kflow class. ToDo for WorkflowRepo class.
    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    550da86 View commit details
    Browse the repository at this point in the history

  4. Implement a private __add_additional_tags() method for the WorkflowRe… 

    …po class in 'nf-core download'.
    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    620ca82 View commit details
    Browse the repository at this point in the history

  5. Experiment with capturing log messages in tests.

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    da0eab1 View commit details
    Browse the repository at this point in the history

  6. Finally managed to assert over log messages, thanks @adamrtalbot .

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    113c9d0 View commit details
    Browse the repository at this point in the history

  7. Update the README.md to reflect the '-a' / '--additional-tags' argume… 

    …nt of 'nf-core download'.
    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    35b4fd6 View commit details
    Browse the repository at this point in the history

  8. Update CHANGELOG: Minor version jump, because CLI arguments changed.

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3901f2d View commit details
    Browse the repository at this point in the history

  9. Ensure a user is configured in Git config. Required for Github Action… 

    …s, but may also affect normal usage.
    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    00cb57e View commit details
    Browse the repository at this point in the history

  10. Catch exceptions if section is missing in the Git config.

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e089676 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
    @MatthiasZepper @mashehu
    MatthiasZepper and mashehu committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6688079 View commit details
    Browse the repository at this point in the history

  12. Update --additional-tag to --tag.

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4d2e681 View commit details
    Browse the repository at this point in the history

  13. Change the e-mail from the nf-core bot e-mail to a sinkhole address.

    @MatthiasZepper
    MatthiasZepper committed May 6, 2024
    Configuration menu
    Copy the full SHA
    0b8e4ad View commit details
    Browse the repository at this point in the history

  14. Rearranging the sentences in README. Thanks @mashehu 

    Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
    @MatthiasZepper @mashehu
    MatthiasZepper and mashehu committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3277b7c View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add deprecation warning for -t / --tower flag.

    @MatthiasZepper
    MatthiasZepper committed May 7, 2024
    Configuration menu
    Copy the full SHA
    1e632c2 View commit details
    Browse the repository at this point in the history

  2. Omit creating heads for additional tags due to UI bug in Platform.

    @MatthiasZepper
    MatthiasZepper committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c95880f View commit details
    Browse the repository at this point in the history