Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code lint CI PR comments to pipeline template #946

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 23, 2021

Added linting CI test PR comments for all code language linting in the pipeline template. Tweaked the markdown comment slightly for tools too.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from KevinMenden March 23, 2021 12:07
Copy link
Contributor

@KevinMenden KevinMenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KevinMenden
Copy link
Contributor

No idea why it doesn't recognise the token. Maybe define it before the with statement as environment variable and then grab it again?

@ewels
Copy link
Member Author

ewels commented Mar 23, 2021

No idea why it doesn't recognise the token. Maybe define it before the with statement as environment variable and then grab it again?

It's not a Jinja variable, it's a GitHub Actions variable. Just needed wrapping in {% raw %} so that Jinja ignores it.

@ewels ewels merged commit e79602e into nf-core:dev Mar 23, 2021
@ewels ewels deleted the code-lint-comments branch March 23, 2021 12:34
@ewels
Copy link
Member Author

ewels commented Mar 23, 2021

After messing with testpipeline for a while to test this, it doesn't work.

Same permissions error we've hit previously where the CI is running on the base fork for a PR and doesn't have permissions to post a comment on the PR. We have a workaround for the nf-core lint results but I'm not sure that I can be bothered to try to do the same for markdownlint and yaml right now.

Will leave in as it works for branches and can try to do this another time maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants