First draft output docs #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpatelh
reviewed
Apr 13, 2020
docs/output.md
Outdated
| [Fastp](https://github.com/OpenGene/fastp) is a tool designed to provide fast all-in-one preprocessing for FastQ files. This tool is developed in C++ with multithreading supported to afford high performance. | ||
|
|
||
| **Output directory: `preprocess/fastp`** | ||
| * `sample.trim.fastq.gz` |
There was a problem hiding this comment.
Suggested change
| * `sample.trim.fastq.gz` | |
| * `<SAMPLE>.trim.fastq.gz` |
There was a problem hiding this comment.
Maybe use that notation throughout?
There was a problem hiding this comment.
Okay I'll replace the rest of the samples and finish polishing it a little bit more.
drpatelh
reviewed
Apr 13, 2020
docs/output.md
Outdated
| @@ -27,6 +47,247 @@ For further reading and documentation see the [FastQC help](http://www.bioinform | |||
| * `zips/sample_fastqc.zip` | |||
| * zip file containing the FastQC report, tab-delimited data file and plot images | |||
|
|
|||
| ### Quality filtering and adaptor rrimming | |||
There was a problem hiding this comment.
Suggested change
| ### Quality filtering and adaptor rrimming | |
| ### Quality filtering and adapter trimming |
There was a problem hiding this comment.
Couple of quick things I spotted :) I'll have a proper look when you have finished.
drpatelh
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nf-core/viralrecon pull request
Many thanks for contributing to nf-core/viralrecon!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md