Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nf-test guidelines for modules and subwfs #2445

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

nvnieuwk
Copy link
Contributor

@nvnieuwk nvnieuwk commented Apr 9, 2024

Adding the guidelines from #2414 to the new docs structure

@netlify /docs/guidelines/components/modules

@nvnieuwk nvnieuwk requested review from mashehu and jfy133 April 9, 2024 13:09
@nvnieuwk nvnieuwk requested a review from a team as a code owner April 9, 2024 13:09
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for nf-core ready!

Name Link
🔨 Latest commit fc31c54
🔍 Latest deploy log https://app.netlify.com/sites/nf-core/deploys/6617cae1e4eb170008de3df2
😎 Deploy Preview https://deploy-preview-2445--nf-core.netlify.app/docs/guidelines/components/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Prefer code blocks over inline code when it's more than a few characters, plus a few too many bullet points for my liking. But all aesthetic suggestions.

src/content/docs/guidelines/components/modules.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/modules.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/modules.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/modules.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/subworkflows.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/subworkflows.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/subworkflows.md Outdated Show resolved Hide resolved
src/content/docs/guidelines/components/subworkflows.md Outdated Show resolved Hide resolved
@ewels ewels merged commit 4edb791 into docs-restructure Apr 11, 2024
7 of 8 checks passed
@ewels ewels deleted the nf-test-review-checklist branch April 11, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants