Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new requirements for stub in module guidelines #2621

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Add new requirements for stub in module guidelines #2621

merged 7 commits into from
Jul 4, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jul 4, 2024

As discussed in office hours

@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited

✅ Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 77d2351
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/6686ea242921ec00082214b7
😎 Deploy Preview https://deploy-preview-2621--nf-core-main-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nvnieuwk
nvnieuwk approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxulysse maxulysse mentioned this pull request Jul 4, 2024
Merged
11 tasks
mirpedrol
mirpedrol approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment •
edited by jfy133

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also open an issue to nf-core/tools to add a linting test for this.

which bit? i can make an issue

@jfy133 @SPPearce @mashehu
Apply suggestions from code review
8db0284 
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mashehu
Copy link
Contributor

mashehu commented Jul 4, 2024

@nf-core-bot fix linting

@jfy133 jfy133 merged commit 477a849 into main Jul 4, 2024
8 checks passed
@jfy133 jfy133 deleted the modules-guidelines branch July 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@SPPearce SPPearce SPPearce left review comments

@maxulysse maxulysse maxulysse approved these changes

@mirpedrol mirpedrol mirpedrol approved these changes

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jfy133 @mashehu @maxulysse @mirpedrol @SPPearce @nvnieuwk @nf-core-bot