Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Labels (comments) for ORCID iDs are currently inconcise. #217

Closed
andreaschrader opened this issue Aug 31, 2023 · 1 comment · Fixed by #219
Closed

[Feature Request] Labels (comments) for ORCID iDs are currently inconcise. #217

andreaschrader opened this issue Aug 31, 2023 · 1 comment · Fixed by #219

Comments

@andreaschrader
Copy link
Member

andreaschrader commented Aug 31, 2023

Is your feature request related to a problem? Please describe.
Orcid iDs are currently added with inconcise lables:
Comment[<Investigation Person ORCID>] for the Investigation Contact Person in the isa.investigation file
Comment[<Investigation Person ORCID>] also for the Study Contact Person in the isa.investigation file
Comment[<Worksheet>] for the Assay Performers added to the Study Contact Person in the isa.investigation file and within the isa.assay file

Describe the solution you'd like
Suggestion:
Comment[<Investigation Person ORCID>] for the Investigation Contact Person in the isa.investigation file
Comment[<Study Person ORCID>] for the Study Contact Person in the isa.investigation file and isa.study file
Comment[<Assay Person ORCID>] for the Assay Performers in the isa.investigation file and isa. assay file (optional also in isa.study file but registered assay's information is currently not updated in there.

  • OS: macOS
  • OS Version Ventura 13.5.1
  • ARC Commander verison: v0.5.0
@andreaschrader andreaschrader changed the title [Feature Request] [Feature Request] Labels (comments) for ORCID iDs are currently inconcise. Aug 31, 2023
@HLWeil
Copy link
Member

HLWeil commented Sep 4, 2023

This will be auto-fixed with the ARCtrl integration (See my comment). If I remember correctly, the ORCID comment string will now always be ORCID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants