Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Add is_a directed search functionality to term search #35

Closed
Freymaurer opened this issue Oct 21, 2020 · 2 comments
Closed

[PR] Add is_a directed search functionality to term search #35

Freymaurer opened this issue Oct 21, 2020 · 2 comments

Comments

@Freymaurer
Copy link
Collaborator

Freymaurer commented Oct 21, 2020 •
edited
Loading

This issue is related to the PR #34. The following notes are copies form the PR.

Features added:

  • Add is_a directed search functionality to term search.
  • Restored bulma imports in style sheets for bulma-extensions switch and tooltip.
  • change addBuildingBlock function to add 3 columns with two cols hidden. These extra columns will hold additional ontology term info in the future
  • add new sql dump with is_a directed search procedure and is_a relationships in TermRelationship table

Do not merge until:

  • is_a directed search returns all children and not only direct children of is_a relationships.
  • insert term function also inserts the additional info in the new extra columns of addBuildingBlock.

As mentioned above there are still major features of this PR missing, so do not merge it yet.
@Freymaurer
Copy link
Collaborator Author

Everything ready for reviewing.

@Freymaurer
Copy link
Collaborator Author

merged and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Freymaurer