Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and lint #11

Merged
merged 4 commits into from
Feb 20, 2022
Merged

Test and lint #11

merged 4 commits into from
Feb 20, 2022

Conversation

JessieFrance
Copy link
Contributor

This PR aims to add tests and linting for #3 as well as GitHub CI. To summarize, the commits add:

  • Mocha tests, similar to the "integration" tests at n_. One test is skipped because it fails on a possible bug. I'm happy to delete that test, or to try to find a fix for it on this or another PR.
  • a GitHub workflow CI similar to the one from shelljs-plugin-inspect. I used this to help me see where tests were passing/failing on Windows and Mac since I use Linux, and to check that applying linting didn't break stuff. Experiments with this CI workflow showed me that the tests work on NodeJS 10 through 14 but fail on NodeJS versions >=15 for Mac, Windows, and Linux with an error message related to repl.history in [DEP0124] DeprecationWarning: REPLServer.rli is deprecated #6. I'm happy to delete/modify this commit though if you don't want it.
  • linting styles (copied over from the test folder at ShellJS).
  • The new linting applied to index.js.

As always, I'm happy to make any changes. It's been fun learning about REPLs. Thank you for the opportunity to learn more about a really cool project!

nfischer
nfischer approved these changes Feb 20, 2022
View reviewed changes
Copy link
Owner

@nfischer nfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks so much for setting this up!

@nfischer nfischer merged commit 24adc87 into nfischer:main Feb 20, 2022
nfischer added a commit that referenced this pull request Feb 20, 2022
@nfischer
chore: follow-up for lint setup
7c14b88 
This is a follow-up to PR #11:

* Register lint as a "posttest" step
* Downgrade eslint so it's compatible with node v10
* Add ">=10" in the engines.node metadata (since this is what CI covers)
* Add my standard ISSUE_TEMPLATE.md, SECURITY.md, and gitattributes
* Add GitHub Actions badge to the README

Issue #3
@nfischer nfischer mentioned this pull request Feb 20, 2022
Merged
nfischer added a commit that referenced this pull request Feb 20, 2022
@nfischer
chore: follow-up for lint setup
1c05ff7 
This is a follow-up to PR #11:

* Register lint as a "posttest" step
* Downgrade eslint so it's compatible with node v10
* Add ">=10" in the engines.node metadata (since this is what CI covers)
* Add my standard ISSUE_TEMPLATE.md, SECURITY.md, and gitattributes
* Add GitHub Actions badge to the README

Issue #3
@JessieFrance JessieFrance deleted the test-and-lint branch February 21, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfischer nfischer nfischer approved these changes

Assignees
No one assigned
Labels
enhancement test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JessieFrance @nfischer