Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace PropTypes #36

Closed
chrisknu opened this issue Apr 24, 2017 · 2 comments
Closed

Namespace PropTypes #36

chrisknu opened this issue Apr 24, 2017 · 2 comments

Comments

@chrisknu
Copy link

Import { PropTypes } from 'react-metrics' may collide with the PropTypes from 'https://www.npmjs.com/package/prop-types'

Suggest namespacing to this package
@nmonti nmonti mentioned this issue May 2, 2017
Closed
@coluccini
Copy link

You can avoid collides by importing with an alias

Import { PropTypes as MetricsPropTypes } from 'react-metrics'

@timothystewart6 timothystewart6 mentioned this issue May 18, 2017
Closed
@LGCambra
Copy link
Member

Closed by #38 and #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed PropTypes timothystewart6/react-metrics
3 participants
@LGCambra @chrisknu @coluccini