Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Attachments #4

Closed
NfNitLoop opened this issue Jan 21, 2021 · 2 comments
Closed

File Attachments #4

NfNitLoop opened this issue Jan 21, 2021 · 2 comments
Assignees
Labels
In Progress Someone's working on this now! planned This is a feature that is planned to be implemented

Comments

@NfNitLoop
Copy link
Owner

Users should be able to attach files to a post. This would make sharing images, PDFs, etc. possible.

Rough plans are:

  • Implement a content-addressable store.
  • Re-use whatever hash-algorithm NaCL signatures currently use, since we're already using it.
  • File names, hashes & sizes are stored within the protobuf.
  • Standard URL sub-directory where files live.
  • File uploads to the file names can be performed by anyone.
  • File attachment quotas may disallow attaching large files.

Additional work:

  • Update the client to know how to sync file attachments along with their Items.
@NfNitLoop NfNitLoop added the planned This is a feature that is planned to be implemented label Jan 21, 2021
@NfNitLoop
Copy link
Owner Author

Do I need to allow for future hash algorithms? Hmm, I guess Protobuf does this for me. I could have a

message File {
    bytes foo_hash = 1
    // ...
}

which just gets deprecated for a new one later.

@NfNitLoop NfNitLoop self-assigned this Feb 12, 2021
@NfNitLoop NfNitLoop added the In Progress Someone's working on this now! label Feb 12, 2021
@NfNitLoop
Copy link
Owner Author

File attachments are now available in v0.3.0. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress Someone's working on this now! planned This is a feature that is planned to be implemented
Projects
None yet
Development

No branches or pull requests

1 participant