Follow symlink directories when zipping #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that symlinks did not appear to be followed when zipping directories on Windows using the NodeZip method. By expanding the pattern in "matches", it now appears to follow those links to the underlying directories and subdirectories. My current directory structure was e.g. ./node_modules/linked_folder/node_modules/(many other folders here). Prior to the change it would just insert the "symlinked folders" as "symlinks" in the zip file. This change will now add the actual folders that were symlinked to (which I *think* makes more sense than how it previously functioned). This has only been validated on a windows machine, so if anyone is on a mac and can test using symlinked folders, please feel free to give that a try. This also allows us to maintain the v0.21.0 archiver rather than upgrading to the latest, which would have many breaking changes.
|
I believe this is superseded by #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that symlinks did not appear to be followed when zipping directories on Windows using the nodeZip method.
By expanding the pattern in "matches", it now appears to follow those links to the underlying directories and subdirectories.
My current directory structure was e.g. ./node_modules/linked_folder/node_modules/(many other folders here). Prior to the change it would just insert the "symlinked folders" as "symlinks" in the zip file. This change will now add the actual folders that were symlinked to (which I think makes more sense than how it previously functioned).
This has only been validated on a windows machine, so if anyone is on a mac and can test using symlinked folders, please feel free to give that a try.
This also allows us to maintain the v0.21.0 archiver rather than upgrading to the latest, which would have many breaking changes.