Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow linked folders #36

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Follow linked folders #36

merged 3 commits into from
Jul 27, 2020

Conversation

dworthen
Copy link
Contributor

  • Upgrade archiver dependency to 4.x
  • Resolves Linked folders not followed #10
    • Add test cases for symlink directories and files.
    • Follow symlink directories and files.
    • Tested on Windows 10 node 12.16.1 and on Ubuntu 18.04 node 12.16.1 with and without native zip.

- Add test cases for file and directory symlinks
- Add support for compressing file and symlinks on Windows
- Test on Windows 10 node 12.16.1
- Test on Ubuntu 18.04 node 12.16.1 both with and without native zip
available in path.
@nfriedly
Copy link
Owner

Nice! (and, sorry for the delay)

I'd prefer for walkDir() be asynchronous, but since this solves an existing issue, I'm going to merge it in now and leave that for the future. I'd love another PR for that, but no worries if you don't have the time.

@nfriedly nfriedly merged commit 3fb9e44 into nfriedly:master Jul 27, 2020
@nfriedly
Copy link
Owner

This should be published in v2.1.6 once the CI loop finishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked folders not followed
2 participants