Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): fix ensure change event and get() have consistent results #1339

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 8, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1339 (65aeed9) into master (52bac24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1339   +/-   ##
=======================================
  Coverage   95.87%   95.88%           
=======================================
  Files         270      270           
  Lines        8300     8301    +1     
  Branches     1634     1634           
=======================================
+ Hits         7958     7959    +1     
  Misses        157      157           
  Partials      185      185           
Impacted Files Coverage Δ
packages/auth/src/token/token.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bac24...65aeed9. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Sep 8, 2021

Preview is ready!

@cipchk cipchk merged commit fddb094 into master Sep 8, 2021
@cipchk cipchk deleted the issues-2087 branch September 8, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokenService.change emits value before it is actually set
2 participants