Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sass-lint): Fix selectors single-line warnings. #109

Merged
merged 2 commits into from
Feb 8, 2018

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented Feb 8, 2018

This includes some minor cleanups to make the animations more readable, which unfortunately increases the complaints about translateY casing (Mixin 'translateY' should be written in lowercase with hyphens mixin-name-format).

This includes some minor cleanups to make the animations more readable, which increases the complaints about translateY casing.
@schmidtk
Copy link
Contributor

schmidtk commented Feb 8, 2018

We're definitely open to suggestions on changes to the SASS linter rules. From the pile of linter warnings we have, it's clearly not something we've nailed down at this point but it's certainly on the agenda. The mixin-name-format rule could absolutely change since it conflicts with Compass mixins we rely on.

@bradh
Copy link
Collaborator Author

bradh commented Feb 8, 2018

Added some per-line suppressions for the mixin-name-format.

@schmidtk schmidtk merged commit 37a5e8e into ngageoint:master Feb 8, 2018
@bradh bradh deleted the lint-single-line branch February 8, 2018 21:46
wallw-teal pushed a commit that referenced this pull request Apr 2, 2018
…HIN-11276 to master

* commit '476342b449a2c6852e5ff34508780a8aacb2f2f4':
  fix(icons): fixes problems with detection and initialization of icon rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants