Fix error creating RSS-feed recall

ngiger · Dec 15, 2015 · be01220 · be01220
1 parent 9ccaad8
commit be01220
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/src/plugin/plugin.rb b/src/plugin/plugin.rb
@@ -80,7 +80,7 @@ def update_yearly_fachinfo_feeds
     def update_rss_feeds(name, model, view_klass, args = nil)
       return if model.empty?
       l10n_sessions do |stub|
-        view = view_klass.new(model, stub, nil, args)
+        view = args ? view_klass.new(model, stub, nil, args) : view_klass.new(model, stub, nil)
         if view.respond_to?(:name=)
           view.name = name
         end

diff --git a/test/test_plugin/plugin.rb b/test/test_plugin/plugin.rb
@@ -80,14 +80,40 @@ def test_resolve_link__error
     end
     def test_update_rss_feeds
       view_instance = flexmock('view_instance', :to_html => 'to_html')
-      view_klass = flexmock('view_klass', :new => view_instance)
+      view_klass = flexmock('view_klass')
+      # new method with 3 arguments as for hpc, price_cut, recall in update_rss_feeds
+      view_klass.should_receive(:new).with(any, any, any).and_return(view_instance)
       name = 'name'
       rss_updates = {'name' => name}
-      flexmock(@app, 
+      flexmock(@app,
                :rss_updates => rss_updates,
                :odba_isolated_store => 'odba_isolated_store'
               )
-      fh = flexmock('file_handler', 
+      fh = flexmock('file_handler',
+                    :puts => nil,
+                    :read => nil
+                   )
+      flexmock(File) do |file|
+        file.should_receive(:open).and_yield(fh)
+        file.should_receive(:mv)
+      end
+      flexmock(FileUtils, :mkdir_p => nil)
+      flexmock(CGI, :new => 'html4')
+      @plugin.instance_eval('@month = Time.local(2011,2)')
+      assert_equal('odba_isolated_store', @plugin.update_rss_feeds('name', ['model'], view_klass))
+    end
+    def test_update_rss_feeds_4_args
+      view_instance = flexmock('view_instance', :to_html => 'to_html')
+      view_klass = flexmock('view_klass')
+      # new method with 4 arguments as for fachinfo in update_rss_feeds
+      view_klass.should_receive(:new).with(any, any, any, any).and_return(view_instance)
+      name = 'name'
+      rss_updates = {'name' => name}
+      flexmock(@app,
+               :rss_updates => rss_updates,
+               :odba_isolated_store => 'odba_isolated_store'
+              )
+      fh = flexmock('file_handler',
                     :puts => nil,
                     :read => nil
                    )