Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns-01 challenge is blowing up simp_le client #68

Closed
briceburg opened this issue Jun 7, 2016 · 6 comments
Closed

dns-01 challenge is blowing up simp_le client #68

briceburg opened this issue Jun 7, 2016 · 6 comments

Comments

@briceburg
Copy link

We've been running this container with success, and so far have been very happy with it. Thanks!

A couple a days ago we started seeing Unhandled errors occuring in the logs. They are coming from the simp_le client when creating/renewing certificates. It appears that the simp_le client is receiving dns-01 challenges from letsencrypt. I imagine it previously received http-01 challenges (e.g. .well-known/acme-challenge response urls) which worked fine.

I'm not sure if it's our configuration or the simp_le client. We're trying to create a cert for the aaa.qa-1.blueacorn.net domain name. debugging shows InitialIP as 66.49.116.181, which aaa.qa-1.blueacorn.net resolves to. Not sure why letsencrypt is sending the dns-01 challenge -- but perhaps it may make sense to move to official client if this goes unresolved?

I've opened an issue on the simp_le project regarding this. kuba/simp_le#110

It contains full debug log. Please let me know if I can help (and/or try alternative clients).

@JrCs
Copy link
Collaborator

JrCs commented Jun 8, 2016

The problem is that the official client didn't check if the certificat need to be update or not.

@briceburg
Copy link
Author

briceburg commented Jul 5, 2016

so as an update -- it seems simp_le + letsencrpyt trigger the dns-01 challenge only if the domain contains uppercase characters. E.g. the VIRTUAL_HOST is set to AAA.qa-1.blueacorn.net (breaks) verses aaa.qa-1.blueacorn.net (works). I'll see if I can submit simp_le a patch -- although there hasn't been any activity there since April.

@briceburg
Copy link
Author

An alternative approach would be to normalize/lowercase the domain names in this container. @JrCs would you be open to a PR for this? or is this something that you believe should be handled upstream in simp_le? Thanks!

@JrCs
Copy link
Collaborator

JrCs commented Jul 6, 2016

No i can make a patch to transform domainname to lower case.
A PR is welcome if you have one.

@JrCs
Copy link
Collaborator

JrCs commented Jul 17, 2016

It's also better if it is fix in simp_le client

@briceburg
Copy link
Author

@JrCs apologies for the radio delay. I agree it's better to fix in simp_le as well -- esp. considering that nginx-proxy enables SSL based on a case-sensitve search for VIRTUAL_HOST.crt in /etc/nginx/certs -- so if we do lowercase it here, we need to make sure to preserve case when generating .crt (which I assume is kind of wonky).

@JrCs JrCs closed this as completed Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants