Improve status API detection and validation #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley
requested review from
oliveromahony,
Dean-Coakley,
craigell and
aphralG
✅ Deploy Preview for agent-public-docs canceled.
|
dhurley
added
bug
aphralG
approved these changes
Aug 22, 2023
Dean-Coakley
approved these changes
Aug 22, 2023
sdk/config_helpers.go
Outdated
|
|
||
| // Expecting API to return the api versions in an array like this: | ||
| // | ||
| // [1,2,3,4,5,6,7,8] |
There was a problem hiding this comment.
[1,2,3,4,5,6,7,8,9] since R30
I'd say give it a more generic comment like expecting API to return a positive integer
oliveromahony
added a commit
that referenced
this pull request
Aug 28, 2023
* fix for dash during upgrade (#450) * Improve status API detection and validation (#447) --------- Co-authored-by: Oliver O'Mahony <oliveromahony+github@gmail.com> * Rebuild selinux policy on RHEL 8 and CentOS 7 (#448) --------- Co-authored-by: oliveromahony <oliveromahony+github@gmail.com> Co-authored-by: Donal Hurley <djhurley1990@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Improve status API detection and validation.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)