Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild selinux policy on RHEL 8 #448

Merged

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Aug 23, 2023

Proposed changes

The following error was seen on RHEL 8 when installing the selinux policy for the nginx-agent:

libsemanage.semanage_pipe_data: Child process /usr/libexec/selinux/hll/pp failed with code: 255. (No such file or directory).
nginx_agent: libsepol.policydb_read: policydb module version 21 does not match my version range 4-19
nginx_agent: libsepol.sepol_module_package_read: invalid module in module package (at section 0)
nginx_agent: Failed to read policy package
libsemanage.semanage_direct_commit: Failed to compile hll files into cil files.
 (No such file or directory).
semodule:  Failed!

To fix this the policy needed to be rebuilt in a RHEL 8 environment.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit f5d8cf1
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64e5e465d9c4f60008de43e6

@dhurley dhurley changed the base branch from main to release-2.28.1 August 23, 2023 10:50
@dhurley dhurley added the bug Something isn't working label Aug 23, 2023
@ross-johnston
Copy link
Collaborator

Hi Donal - do you know if this also works on centos-7?

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.20% ⚠️

Comparison is base (7c1ada3) 67.19% compared to head (d0a2c9a) 67.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-2.28.1     #448      +/-   ##
==================================================
- Coverage           67.19%   67.00%   -0.20%     
==================================================
  Files                 113      113              
  Lines               12849    12849              
==================================================
- Hits                 8634     8609      -25     
- Misses               3647     3673      +26     
+ Partials              568      567       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhurley
Copy link
Collaborator Author

dhurley commented Aug 25, 2023

Hi Donal - do you know if this also works on centos-7?

Yeah just verified the fix on Centos 7 as well

@oliveromahony oliveromahony merged commit 4027827 into release-2.28.1 Aug 28, 2023
23 checks passed
@oliveromahony oliveromahony deleted the fix-selinux-policydb-module-version-mismatch branch August 28, 2023 09:41
oliveromahony added a commit that referenced this pull request Aug 28, 2023
* fix for dash during upgrade (#450)

* Improve status API detection and validation (#447)

---------

Co-authored-by: Oliver O'Mahony <oliveromahony+github@gmail.com>

* Rebuild selinux policy on RHEL 8 and CentOS 7 (#448)

---------

Co-authored-by: oliveromahony <oliveromahony+github@gmail.com>
Co-authored-by: Donal Hurley <djhurley1990@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants