Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for dash during upgrade #450

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix for dash during upgrade #450

merged 1 commit into from
Aug 24, 2023

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Filter out commands that include upgrade in the command (how NGINX updates)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Aug 24, 2023
@oliveromahony oliveromahony merged commit 61b0779 into release-2.28.1 Aug 24, 2023
23 checks passed
@oliveromahony oliveromahony deleted the process-tightening branch August 24, 2023 16:02
oliveromahony added a commit that referenced this pull request Aug 28, 2023
@github-actions @oliveromahony @dhurley
Merge release-2.28.1 back into main (#455)
3e8efee 
* fix for dash during upgrade (#450)

* Improve status API detection and validation (#447)

---------

Co-authored-by: Oliver O'Mahony <oliveromahony+github@gmail.com>

* Rebuild selinux policy on RHEL 8 and CentOS 7 (#448)

---------

Co-authored-by: oliveromahony <oliveromahony+github@gmail.com>
Co-authored-by: Donal Hurley <djhurley1990@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@aphralG aphralG aphralG approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliveromahony @Dean-Coakley @aphralG