Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Specification errors #938

Closed
Pavlusha311245 opened this issue Sep 5, 2023 · 4 comments
Closed

OpenAPI Specification errors #938

Pavlusha311245 opened this issue Sep 5, 2023 · 4 comments
Labels
z-documentation-update-needed This type of issues likely have a link to an issue in the Unit Docs repo z-enhancement ⬆️ Product Enhancement

Comments

@Pavlusha311245
Copy link

I downloaded the OpenAPI specification and in some sample responses I get values like in the screenshot. For example, the /certificates/:bundle endpoint should have returned an error with the error key, but not two keys named sit_7 and incididuntdb2. The specification is taken from the official site.
One possible reason for the incorrect display is the use of Postman, check if possible. On the first screenshot you can see that inside OpenAPI file is described kind of correctly
Also OpenAPI does not contain an update of Nginx Unit 1.31.0 version

image image
@tippexs
Copy link
Contributor

tippexs commented Sep 6, 2023

Thanks for sharing this with us! We will take a look and provide an updated version of the spec ASAP!

@tippexs tippexs added z-enhancement ⬆️ Product Enhancement z-documentation-update-needed This type of issues likely have a link to an issue in the Unit Docs repo labels Sep 6, 2023
@Pavlusha311245
Copy link
Author

@tippexs In addition, you can create a public API in Postman. I'm not sure if this solution is free, so it's at your discretion.
image

@tippexs
Copy link
Contributor

tippexs commented Sep 8, 2023

Thanks for this. He have not shared anything as a public Postman API yet, but this does not mean we are not able to explore this option. We will have a look on it.

@ghost ghost self-assigned this Oct 11, 2023
@ghost
Copy link

ghost commented Oct 17, 2023

hi! there's a lot reported here, so let's discuss each item separately:

  1. PUT @ /certificates/:bundle - can't reproduce; indeed, looks like something out of Postman itself, given the telling name "incididunt" is a part of lorem ipsum stubs that Postman uses

  2. 1.31.0 - updated recently, https://hg.nginx.org/unit/rev/cfd5bf6e4324 and https://hg.nginx.org/unit/rev/438271da6ff4 for instance.

  3. The Public API network is rather intended for singleton public APIs, not per-instance APIs, it seems.

@ghost ghost closed this as completed Oct 17, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
z-documentation-update-needed This type of issues likely have a link to an issue in the Unit Docs repo z-enhancement ⬆️ Product Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants