feat: upgrade to Angular 17 #632

Tommy228 · 2023-11-19T22:03:37Z

ran ng update @angular/cli @angular/core
updated eslint dependencies
updated jest dependencies

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngneat/spectator/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #631

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Angular recently introduced TestBed.flushEffects() which is a helper function to execute pending effects . I think it makes sense to add spectator.flushEffects() but the method is still under dev preview, so maybe not the right time?

stackblitz · 2023-11-19T22:03:41Z

Run & review this pull request in StackBlitz Codeflow.

chimurai

peerDependencies needs to be updated:

spectator/projects/spectator/package.json

Lines 32 to 34 in 9478289

    
           "@angular/common": ">= 16.0.0", 
        
           "@angular/router": ">= 16.0.0", 
        
           "@angular/animations": ">= 16.0.0"

NetanelBasal · 2023-11-20T06:17:00Z

You can add spectator.flushEffects() and also introduce a an API to test defer views.

chimurai · 2023-11-25T11:28:10Z

Running yarn build fails:

$ yarn build
yarn run v1.22.21
$ ng build --configuration production && yarn build:schematics && yarn copy:schematics && yarn copy:docs
Building Angular Package

------------------------------------------------------------------------------
Building entry point '@ngneat/spectator/internals'
------------------------------------------------------------------------------
✖ Compiling with Angular sources in Ivy partial compilation mode.
error TS2688: Cannot find type definition file for 'jasmine'.
  The file is in the program because:
    Entry point of type library 'jasmine' specified in compilerOptions
error TS2688: Cannot find type definition file for 'node'.
  The file is in the program because:
    Entry point of type library 'node' specified in compilerOptions

error Command failed with exit code 1.

Updating jest and @types/jest to latest and patching spectator/tsconfig.lib.json seems to fix it:

package.json:

"@types/jest": "29.5.10",
"jest": "29.7.0",

index adeaf7c4..8566c2b4 100644
--- a/projects/spectator/tsconfig.lib.json
+++ b/projects/spectator/tsconfig.lib.json
@@ -6,10 +6,10 @@
     "declaration": true,
     "inlineSources": true,
     "typeRoots": [
+      "../../node_modules/@types",
       "./typings"
     ],
     "types": [
-      "jasmine",
       "jest",
       "node"
     ],

-- edit 2023-12-02 --

Suggested incorrect patch.
Adding "../../node_modules/@types" at the end of typeRoots fixes the issue

https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/

index adeaf7c4..8566c2b4 100644
--- a/projects/spectator/tsconfig.lib.json
+++ b/projects/spectator/tsconfig.lib.json
@@ -6,10 +6,10 @@
     "declaration": true,
     "inlineSources": true,
     "typeRoots": [
-       "./typings"
+       "./typings",
+      "../../node_modules/@types"
     ],

Tommy228 · 2023-11-26T17:18:39Z

Thanks, it's fixed now. I've tried running this on a big project under ng17 with yarn link but I'm having some typing errors

Property 'service' does not exist on type 'SpectatorService<TestService>'.

The generated dist looks fine though. I'm trying to understand why, maybe it's just an issue with my local setup.

NetanelBasal · 2023-11-28T20:24:14Z

@Tommy228 try with verdaccio

Tommy228 · 2023-11-28T20:46:24Z

Thanks, that worked. I didn't know about it, pretty handy :)

I have just tried the upgrade on an Angular 17 project with 4000+ tests with Spectator and Jest, works fine.

- ran ng update @angular/cli @angular/core - updated eslint dependencies - updated jest dependencies

NetanelBasal · 2023-11-29T07:37:25Z

projects/spectator/tsconfig.lib.json

@@ -6,10 +6,10 @@
    "declaration": true,
    "inlineSources": true,
    "typeRoots": [
+      "../../node_modules/@types",


Can you explain this change, please?

typescript got upgraded from 5.0.4 to 5.2.2

Typescript 5.1 introduced a change in typeRoots behaviour:

Explicit typeRoots Disables Upward Walks for node_modules/@types

More info: https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/

Looking at the Microsoft documentation the order of typeRoots should be corrected to:

"typeRoots": [ "./typings", "../../node_modules/@types" ],

NetanelBasal · 2023-12-02T16:34:22Z

projects/spectator/tsconfig.lib.json

      "./typings"
    ],
    "types": [
-      "jasmine",


Why we remove jasmine from here?

chimurai · 2023-12-02T16:33:55Z

projects/spectator/tsconfig.lib.json

@@ -6,10 +6,10 @@
    "declaration": true,
    "inlineSources": true,
    "typeRoots": [
+      "../../node_modules/@types",


Looking at the Microsoft documentation the order of typeRoots should be corrected to:

"typeRoots": [ "./typings", "../../node_modules/@types" ],

chimurai · 2023-12-02T16:34:22Z

projects/spectator/tsconfig.lib.json

      "./typings"
    ],
    "types": [
-      "jasmine",


jasmine type should remain.

NetanelBasal · 2023-12-02T16:34:55Z

@Tommy228 your project is using jest or jasmine?

Tommy228 · 2023-12-02T18:13:56Z

My project uses jest, so I didn’t test it under jasmine. Indeed, we should add it back. I can’t update the PR before a few days so feel free to do it if you want to.

lneumeier · 2023-12-11T12:25:22Z

My project uses jest, so I didn’t test it under jasmine. Indeed, we should add it back. I can’t update the PR before a few days so feel free to do it if you want to.

I created a new pull-request.
#633

chimurai suggested changes Nov 19, 2023

View reviewed changes

Tommy228 force-pushed the master branch from 8d8c32a to c8bb80f Compare November 20, 2023 07:00

Tommy228 force-pushed the master branch from c8bb80f to 8cef547 Compare November 26, 2023 17:05

Tommy228 force-pushed the master branch 2 times, most recently from f963e6a to 777c67e Compare November 28, 2023 20:49

feat: upgrade to Angular 17

5d48789

- ran ng update @angular/cli @angular/core - updated eslint dependencies - updated jest dependencies

Tommy228 force-pushed the master branch from 777c67e to 5d48789 Compare November 28, 2023 20:50

NetanelBasal reviewed Nov 29, 2023

View reviewed changes

NetanelBasal reviewed Dec 2, 2023

View reviewed changes

projects/spectator/tsconfig.lib.json

"./typings"

],

"types": [

"jasmine",

Copy link

Member

NetanelBasal Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we remove jasmine from here?

chimurai suggested changes Dec 2, 2023

View reviewed changes

Tommy228 closed this Dec 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade to Angular 17 #632

feat: upgrade to Angular 17 #632

Tommy228 commented Nov 19, 2023

stackblitz bot commented Nov 19, 2023

chimurai left a comment

NetanelBasal commented Nov 20, 2023

chimurai commented Nov 25, 2023 •

edited

Loading

Tommy228 commented Nov 26, 2023

NetanelBasal commented Nov 28, 2023

Tommy228 commented Nov 28, 2023

NetanelBasal Nov 29, 2023

chimurai Dec 2, 2023

chimurai Dec 2, 2023 •

edited

Loading

NetanelBasal Dec 2, 2023

chimurai Dec 2, 2023 •

edited

Loading

chimurai Dec 2, 2023

NetanelBasal commented Dec 2, 2023

Tommy228 commented Dec 2, 2023

lneumeier commented Dec 11, 2023

	"@angular/common": ">= 16.0.0",
	"@angular/router": ">= 16.0.0",
	"@angular/animations": ">= 16.0.0"

feat: upgrade to Angular 17 #632

feat: upgrade to Angular 17 #632

Conversation

Tommy228 commented Nov 19, 2023

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

stackblitz bot commented Nov 19, 2023

chimurai left a comment

Choose a reason for hiding this comment

NetanelBasal commented Nov 20, 2023

chimurai commented Nov 25, 2023 • edited Loading

Tommy228 commented Nov 26, 2023

NetanelBasal commented Nov 28, 2023

Tommy228 commented Nov 28, 2023

NetanelBasal Nov 29, 2023

Choose a reason for hiding this comment

chimurai Dec 2, 2023

Choose a reason for hiding this comment

chimurai Dec 2, 2023 • edited Loading

Choose a reason for hiding this comment

NetanelBasal Dec 2, 2023

Choose a reason for hiding this comment

chimurai Dec 2, 2023 • edited Loading

Choose a reason for hiding this comment

chimurai Dec 2, 2023

Choose a reason for hiding this comment

NetanelBasal commented Dec 2, 2023

Tommy228 commented Dec 2, 2023

lneumeier commented Dec 11, 2023

chimurai commented Nov 25, 2023 •

edited

Loading

chimurai Dec 2, 2023 •

edited

Loading

chimurai Dec 2, 2023 •

edited

Loading