Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 17 #633

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Angular 17 #633

merged 2 commits into from
Dec 16, 2023

Conversation

lneumeier
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #631

What is the new behavior?

  • support angular 17

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@lneumeier lneumeier mentioned this pull request Dec 11, 2023
Closed
3 tasks
@NetanelBasal
Copy link
Member

Please update the commit message using npm run commit and mark it as a breaking change.

@lneumeier
feat: 🎸 upgrade to Angular 17
44f17f4 
Upgrade packages and dependencies

BREAKING CHANGE: 🧨 The library now requires a minimum version of Angular 17.0.0

✅ Closes: #631
@lneumeier
feat: 🎸 upgrade to Angular 17
5bab7ff 
Added a wrapper for Angular 17 TestBed.flushEffects()

✅ Closes: #631
@lneumeier
Copy link
Contributor Author

@NetanelBasal

Should I update the spectator version as well because of a breaking change or is this something you do?

@NetanelBasal
Copy link
Member

No, only the commit message

@lneumeier
Copy link
Contributor Author

lneumeier commented Dec 16, 2023 •
edited

I updated the commit messages.

Edit:
I had to create new commits in order to run "npm run commit" command.

@NetanelBasal NetanelBasal merged commit b064ea7 into ngneat:master Dec 16, 2023
3 checks passed
@lneumeier lneumeier deleted the angular-17 branch December 16, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lneumeier @NetanelBasal