Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 17 #631

Closed
vecernik opened this issue Nov 10, 2023 · 2 comments
Closed

Support Angular 17 #631

vecernik opened this issue Nov 10, 2023 · 2 comments

Comments

@vecernik
Copy link

Is this a regression?

Yes

Description

Please add a support for styleUrl (singular) in components.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

Component 'TopSearchHeaderComponent' is not resolved:
 - styleUrl: ./top-search-header.component.scss
Did you run and wait for 'resolveComponentResources()'?

  let s: Spectator<TopSearchHeaderComponent>

  const createComponent = createComponentFactory({
    component: TopSearchHeaderComponent,
    imports: [ MatIconTestingModule ],
  })

Please provide the environment you discovered this bug in

Nx workspace @nx/jest 17.1.1, Spectator 15.0.1, jest 29.7.0, jest-preset-angular 13.1.3

Anything else?

No response

Do you want to create a pull request?

Yes

@netanel-utila
Copy link
Contributor

You are welcome to create a PR that upgrades to v17

@NetanelBasal NetanelBasal changed the title Support for Angular 17's styleUrl Support Angular 17 Nov 12, 2023
@lneumeier lneumeier mentioned this issue Dec 11, 2023
3 tasks
@timonmasberg
Copy link

I still have this issue with the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants