Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module loader library to documentation #37

Closed
larscom opened this issue Aug 25, 2019 · 5 comments

Comments

@larscom
Copy link

commented Aug 25, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[X ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

What is the motivation / use case for changing the behavior?

I've ported a library (from ngx-translate) to transloco, its my own library for loading mutliple translations via http. Would love to see it in the transloco documentation 😃

Library: https://github.com/larscom/transloco-module-loader

Working demo: https://stackblitz.com/edit/transloco-module-loader

@shaharkazaz

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2019

Nice! would you like to make it an official plugin for transloco? 😃

@NetanelBasal

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2019

@larscom thanks for your work. I think that your functionality is already provided out of the box in Transloco (with lazy scoping). Can you verify it from this comment, please?

@larscom

This comment has been minimized.

Copy link
Author

commented Aug 25, 2019

@NetanelBasal i think you are right! Great work 😃

@larscom larscom closed this Aug 25, 2019

@NetanelBasal

This comment has been minimized.

Copy link
Collaborator

commented Aug 25, 2019

@larscom We really do appreciate the effort, and we'll add you to the contributors' list. We'd love to see more of you in the future 💯.

@larscom

This comment has been minimized.

Copy link
Author

commented Aug 25, 2019

@larscom We really do appreciate the effort, and we'll add you to the contributors' list. We'd love to see more of you in the future .

Thanks alot! appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.