Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime errors after adding untilDestroyed to Angular 7 project #23

Closed
wilgert opened this issue Nov 15, 2018 · 3 comments
Closed

Runtime errors after adding untilDestroyed to Angular 7 project #23

wilgert opened this issue Nov 15, 2018 · 3 comments

Comments

@wilgert
Copy link

wilgert commented Nov 15, 2018

Adding pipe(untilDestroyed(this)) to all subscriptions made in our components makes some components to cause runtime errors.

Like this one:
screen shot 2018-11-15 at 13 55 20

Versions
@angular/*: 7.0.0
ngx-take-until-destroy: 5.2.3

@NetanelBasal
Copy link
Member

It seems like someone created a read-only property named ngOnDestroy . It works fine with ng7.
https://stackblitz.com/edit/ngx-take-until-demo

@NetanelBasal
Copy link
Member

Check your code.

@ajaynarang
Copy link

I am also getting this issue with latest Angular version, seems like issue is something else not related to Angular 7.

For some components it works fine but randomly it throws this exception, probably something to do with Angular page cycle which keeps ngOnDestroy readonly till initialization is over. Tried to debug but couldn't figure out the root problem.

Appreciate any help. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants