Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Improve footer layout #623

Closed
3 tasks done
rupali-codes opened this issue Apr 9, 2023 · 9 comments · Fixed by #663
Closed
3 tasks done

[CHORE] Improve footer layout #623

rupali-codes opened this issue Apr 9, 2023 · 9 comments · Fixed by #663
Assignees
Labels
area/logic This issue is related to a logic fix. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@rupali-codes
Copy link
Contributor

What would you like to share?

Currently, the footer is having too much gap between the elements, and it looks kinda empty, it would lead to such a nice user experience if we can improve the layout a bit.

Suggestions

  • Add Milan icon in contribute section
  • Shift Join us links and Report section to right
  • Make footer a bit darker
  • Make GitHub logo bright

🥦 Browser

Brave

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (blank for no)
@rupali-codes rupali-codes added ✨ goal: improvement status: wip 👩🏻‍💻 This issue/PR is actively being worked on. labels Apr 9, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Hello contributor, thank you for opening an Issue 🎉.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out Tamal Das on Twitter.
Star ⭐ this repo to show us support.

Happy, Open Source!

@Deva-1903
Copy link
Contributor

Can I work on this issue?

@tamalCodes
Copy link
Member

Sounds good @rupali-codes 🔥

@tamalCodes tamalCodes added the area/logic This issue is related to a logic fix. label Apr 13, 2023
@Deva-1903
Copy link
Contributor

I inquired four days in advance whether it was available for work, and if so, please assign it to me.

@tamalCodes
Copy link
Member

I inquired four days in advance whether it was available for work, and if so, please assign it to me.

Hi @Deva-1903 , to solve confusion like this, we have a checkbox for the person who is raising the issue. It's clearly written to tick the box if they want to work on the issue.

Since they have done so, I assigned them. If they don't want to, I'll assign you.
Thanks.

image

@Deva-1903
Copy link
Contributor

Sorry, I missed it. I appreciate your saying @iamtamal

@rupali-codes
Copy link
Contributor Author

Hey @iamtamal thanks for assigning, will rise the PR soon

@rupali-codes
Copy link
Contributor Author

Whoops, i'm sorry i was totally forgot about this, i'll rise the PR today by evening :)

@jayk-gupta
Copy link

Also the background color could be changed according to the theme, may be light red.
Let me know if I can contribute anything to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants