-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no heading tags in footer #1049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @badrivlog, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work !
The changes look good to me and will be merged soon.
Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !
Happy Opensource 🚀.
This pull request has been deployed to Vercel.
|
* feat: merging the authentication pages of 2 different types of users into a single one (#1041) * feat: enable direct access to signup/signin form from respective buttons * fix: fixed bug in signin * feat: merging the authentication pages of 2 different types of users into a single one * chore: improve .gitignore and remove .DS_Store (#1010) * chore: update .gitignore * chore: delete .DS_Store * chore: remove unnecessary files as per codebase --------- Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to tests & cleanup * fix: added conditional rendering to clubs data * docs: updates to grammars and new shield icons * fix: revamping the tags in the footer (#1049) Co-authored-by: Tamal Das <tamalcodes@gmail.com> * fix: registration zipcode length issue (#1057) * fix: go back button return to home (#1056) Co-authored-by: parth <parth@gmail.com> Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to the auth logics (#1063) --------- Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com> Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com> Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com> Co-authored-by: parth <parth@gmail.com>
* feat: merging the authentication pages of 2 different types of users into a single one (#1041) * feat: enable direct access to signup/signin form from respective buttons * fix: fixed bug in signin * feat: merging the authentication pages of 2 different types of users into a single one * chore: improve .gitignore and remove .DS_Store (#1010) * chore: update .gitignore * chore: delete .DS_Store * chore: remove unnecessary files as per codebase --------- Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to tests & cleanup * fix: added conditional rendering to clubs data * docs: updates to grammars and new shield icons * fix: revamping the tags in the footer (#1049) Co-authored-by: Tamal Das <tamalcodes@gmail.com> * fix: registration zipcode length issue (#1057) * fix: go back button return to home (#1056) Co-authored-by: parth <parth@gmail.com> Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to the auth logics (#1063) * fix: adress breakdown when signing up (#1067) * feat: new files for authentication * fix: renaming css file * fix: removing extra codes * fix: changes to links & workflow branch * fix: changes to the callback names * feat: google auth and optimizations --------- Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com> Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com> Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com> Co-authored-by: parth <parth@gmail.com>
🚧 Fixes Issue
closes #1039
Changes made :
ToastContainer
andModal
component outside from the footerh1
tag withp
tag.Screenshots 📸
after made changes
![milan](https://private-user-images.githubusercontent.com/73095526/261860747-a15306c2-4c8d-4362-b829-485d0cd9d960.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAyNDk4OTQsIm5iZiI6MTcyMDI0OTU5NCwicGF0aCI6Ii83MzA5NTUyNi8yNjE4NjA3NDctYTE1MzA2YzItNGM4ZC00MzYyLWI4MjktNDg1ZDBjZDlkOTYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA2VDA3MDYzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY5YTA1OTE5YmIwYzA2MTliMjM4YzlkZjQwNzEzZGE1MGQ0YTk2MjczOGUxNDg5YTY2ZDg3ZWYzMTZjMjUzMmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.W6lbl5uucqMKJu-tZ1qyUGjkwdSWfDwmnEi9sr1yNfo)