fix: zipcode lenght issue for registration #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🐞 bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Giuliano1993, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/%F0%9F%91%B7%F0%9F%8F%BB%E2%80%8D%E2%99%82%EF%B8%8F%20status%3A%20awaiting%20triage which means that work for this issue is on hold and we are waiting for the maintainers/owner to review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
|
This pull request has been deployed to Vercel.
|
github-actions
bot
added
the
deployed
tamalCodes
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Amazing work !
The changes look good to me and will be merged soon.
Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !
Happy Opensource 🚀.
tamalCodes
added
area/logic
tamalCodes
added a commit
that referenced
this pull request
Aug 31, 2023
* feat: merging the authentication pages of 2 different types of users into a single one (#1041) * feat: enable direct access to signup/signin form from respective buttons * fix: fixed bug in signin * feat: merging the authentication pages of 2 different types of users into a single one * chore: improve .gitignore and remove .DS_Store (#1010) * chore: update .gitignore * chore: delete .DS_Store * chore: remove unnecessary files as per codebase --------- Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to tests & cleanup * fix: added conditional rendering to clubs data * docs: updates to grammars and new shield icons * fix: revamping the tags in the footer (#1049) Co-authored-by: Tamal Das <tamalcodes@gmail.com> * fix: registration zipcode length issue (#1057) * fix: go back button return to home (#1056) Co-authored-by: parth <parth@gmail.com> Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to the auth logics (#1063) --------- Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com> Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com> Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com> Co-authored-by: parth <parth@gmail.com>
tamalCodes
added a commit
that referenced
this pull request
Sep 10, 2023
* feat: merging the authentication pages of 2 different types of users into a single one (#1041) * feat: enable direct access to signup/signin form from respective buttons * fix: fixed bug in signin * feat: merging the authentication pages of 2 different types of users into a single one * chore: improve .gitignore and remove .DS_Store (#1010) * chore: update .gitignore * chore: delete .DS_Store * chore: remove unnecessary files as per codebase --------- Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to tests & cleanup * fix: added conditional rendering to clubs data * docs: updates to grammars and new shield icons * fix: revamping the tags in the footer (#1049) Co-authored-by: Tamal Das <tamalcodes@gmail.com> * fix: registration zipcode length issue (#1057) * fix: go back button return to home (#1056) Co-authored-by: parth <parth@gmail.com> Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to the auth logics (#1063) * fix: adress breakdown when signing up (#1067) * feat: new files for authentication * fix: renaming css file * fix: removing extra codes * fix: changes to links & workflow branch * fix: changes to the callback names * feat: google auth and optimizations --------- Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com> Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com> Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com> Co-authored-by: parth <parth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1055
👷🏻 Changes made
Just needed to handle the length of zipcode for most countries, so i added a check in the useValidation hook to accept not only 6 characters long zip codes but also the ones long 5 characters