Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing code duplicacies in authentication #1063

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

tamalCodes
Copy link
Member

👷🏻 Changes made

  • Cleanup for duplicate codes
  • re-using authentication logic with a new useFormLogic

@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🐞 bug This is a patch, generally fixing some bugs. Beta Release The changes in the Issue/PR are in beta stage, and might be unstable in production. labels Aug 31, 2023
@tamalCodes tamalCodes self-assigned this Aug 31, 2023
@github-actions github-actions bot added the status: todo ⏳ This issue is yet to be seen by the maintainer of the project. label Aug 31, 2023
github-actions[bot]

This comment was marked as outdated.

@github-actions github-actions bot temporarily deployed to Preview August 31, 2023 07:00 Inactive
@github-actions github-actions bot temporarily deployed to Preview August 31, 2023 07:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview August 31, 2023 07:01 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Aug 31, 2023
@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 10733e8
✅ Preview: https://milan-beta-2h5zt9s51-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan-beta/6zmAJ1yVmCMnAt8kn8emLqYYCJoG

View Workflow Logs

@tamalCodes tamalCodes merged commit 44b7180 into beta Aug 31, 2023
4 checks passed
tamalCodes added a commit that referenced this pull request Aug 31, 2023
* feat: merging the authentication pages of 2 different types of users into a single one (#1041)

* feat: enable direct access to signup/signin form from respective buttons

* fix: fixed bug in signin

* feat: merging the authentication pages of 2 different types of users into a single one

* chore: improve .gitignore and remove .DS_Store (#1010)

* chore: update .gitignore

* chore: delete .DS_Store

* chore: remove unnecessary files as per codebase

---------

Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* chore(refactor): changes to tests & cleanup

* fix: added conditional rendering to clubs data

* docs: updates to grammars and new shield icons

* fix: revamping the tags in the footer (#1049)

Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* fix: registration zipcode length issue (#1057)

* fix: go back button return to home (#1056)

Co-authored-by: parth <parth@gmail.com>
Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* chore(refactor): changes to the auth logics (#1063)

---------

Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com>
Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com>
Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com>
Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com>
Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com>
Co-authored-by: parth <parth@gmail.com>
tamalCodes added a commit that referenced this pull request Sep 10, 2023
* feat: merging the authentication pages of 2 different types of users into a single one (#1041)

* feat: enable direct access to signup/signin form from respective buttons

* fix: fixed bug in signin

* feat: merging the authentication pages of 2 different types of users into a single one

* chore: improve .gitignore and remove .DS_Store (#1010)

* chore: update .gitignore

* chore: delete .DS_Store

* chore: remove unnecessary files as per codebase

---------

Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* chore(refactor): changes to tests & cleanup

* fix: added conditional rendering to clubs data

* docs: updates to grammars and new shield icons

* fix: revamping the tags in the footer (#1049)

Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* fix: registration zipcode length issue (#1057)

* fix: go back button return to home (#1056)

Co-authored-by: parth <parth@gmail.com>
Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* chore(refactor): changes to the auth logics (#1063)

* fix: adress breakdown when signing up (#1067)

* feat: new files for authentication

* fix: renaming css file

* fix: removing extra codes

* fix: changes to links & workflow branch

* fix: changes to the callback names

* feat: google auth and optimizations

---------

Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com>
Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com>
Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com>
Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com>
Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com>
Co-authored-by: parth <parth@gmail.com>
@tamalCodes tamalCodes deleted the code-cleanup branch January 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. Beta Release The changes in the Issue/PR are in beta stage, and might be unstable in production. 🐞 bug This is a patch, generally fixing some bugs. deployed This PR has been deployed to Vercel for testing. status: todo ⏳ This issue is yet to be seen by the maintainer of the project.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

None yet

1 participant