-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removing code duplicacies in authentication #1063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been deployed to Vercel.
|
tamalCodes
added a commit
that referenced
this pull request
Aug 31, 2023
* feat: merging the authentication pages of 2 different types of users into a single one (#1041) * feat: enable direct access to signup/signin form from respective buttons * fix: fixed bug in signin * feat: merging the authentication pages of 2 different types of users into a single one * chore: improve .gitignore and remove .DS_Store (#1010) * chore: update .gitignore * chore: delete .DS_Store * chore: remove unnecessary files as per codebase --------- Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to tests & cleanup * fix: added conditional rendering to clubs data * docs: updates to grammars and new shield icons * fix: revamping the tags in the footer (#1049) Co-authored-by: Tamal Das <tamalcodes@gmail.com> * fix: registration zipcode length issue (#1057) * fix: go back button return to home (#1056) Co-authored-by: parth <parth@gmail.com> Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to the auth logics (#1063) --------- Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com> Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com> Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com> Co-authored-by: parth <parth@gmail.com>
tamalCodes
added a commit
that referenced
this pull request
Sep 10, 2023
* feat: merging the authentication pages of 2 different types of users into a single one (#1041) * feat: enable direct access to signup/signin form from respective buttons * fix: fixed bug in signin * feat: merging the authentication pages of 2 different types of users into a single one * chore: improve .gitignore and remove .DS_Store (#1010) * chore: update .gitignore * chore: delete .DS_Store * chore: remove unnecessary files as per codebase --------- Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to tests & cleanup * fix: added conditional rendering to clubs data * docs: updates to grammars and new shield icons * fix: revamping the tags in the footer (#1049) Co-authored-by: Tamal Das <tamalcodes@gmail.com> * fix: registration zipcode length issue (#1057) * fix: go back button return to home (#1056) Co-authored-by: parth <parth@gmail.com> Co-authored-by: Tamal Das <tamalcodes@gmail.com> * chore(refactor): changes to the auth logics (#1063) * fix: adress breakdown when signing up (#1067) * feat: new files for authentication * fix: renaming css file * fix: removing extra codes * fix: changes to links & workflow branch * fix: changes to the callback names * feat: google auth and optimizations --------- Co-authored-by: Vansh Gandhi <vansh.vg18@gmail.com> Co-authored-by: Anmol Baranwal <74038190+Anmol-Baranwal@users.noreply.github.com> Co-authored-by: Baidyanath Sarkar <73095526+badrivlog@users.noreply.github.com> Co-authored-by: Ghostylab <giuliano.gostinfini.93@gmail.com> Co-authored-by: Steakysteak <75496668+Steakysteak@users.noreply.github.com> Co-authored-by: parth <parth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/logic
This issue is related to a logic fix.
Beta Release
The changes in the Issue/PR are in beta stage, and might be unstable in production.
🐞 bug
This is a patch, generally fixing some bugs.
deployed
This PR has been deployed to Vercel for testing.
status: todo ⏳
This issue is yet to be seen by the maintainer of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👷🏻 Changes made
useFormLogic