Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

muxado: some minor cleanup #28

Merged
merged 2 commits into from
Dec 14, 2022
Merged

muxado: some minor cleanup #28

merged 2 commits into from
Dec 14, 2022

Conversation

jrobsonchase
Copy link
Collaborator

@jrobsonchase jrobsonchase commented Dec 14, 2022 •
edited
Loading

  • removes unneeded features
  • no more panics on window underflow
    It's possible that these are indicative of another bug, but we might have better luck finding it if it doesn't cause a panic here. (investigate wndinc underflows in muxado #29)

@jrobsonchase jrobsonchase marked this pull request as ready for review December 14, 2022 16:18
bobzilladev
bobzilladev approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 2+2 is unlikely to change

@jrobsonchase jrobsonchase merged commit 7491ab7 into main Dec 14, 2022
@jrobsonchase jrobsonchase deleted the josh/muxado-cleanup branch December 14, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzilladev bobzilladev bobzilladev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrobsonchase @bobzilladev