Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add release checks and jobs #42

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

jrobsonchase
Copy link
Collaborator

@jrobsonchase jrobsonchase commented Jan 6, 2023

Alright, I'm reasonably happy with this now. Semver checks now happen before PR merge, and once it hits master, it'll always try to publish, and if the publish succeeds, it'll add a git tag for us.

So all we have to do to publish is make a PR with a version bump!

@jrobsonchase jrobsonchase force-pushed the josh/nix/semver-checks branch 7 times, most recently from 2d341a5 to 17f4d6e Compare January 12, 2023 16:46
@jrobsonchase jrobsonchase changed the title experiment with pre-release semver checking ci: Add release checks and jobs Jan 24, 2023
@jrobsonchase jrobsonchase marked this pull request as ready for review January 24, 2023 00:04
Copy link
Contributor

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. stealing the repository check for ngrok-js.

.github/workflows/ci.yml Show resolved Hide resolved
@jrobsonchase jrobsonchase merged commit 9366dc8 into main Jan 24, 2023
@jrobsonchase jrobsonchase deleted the josh/nix/semver-checks branch January 24, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants