Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

Content handler options not fully accessible #55

Closed
nblumoe opened this issue Jan 7, 2016 · 0 comments
Closed

Content handler options not fully accessible #55

nblumoe opened this issue Jan 7, 2016 · 0 comments

Comments

@nblumoe
Copy link

nblumoe commented Jan 7, 2016

It's not possible to pass all the options down to the handler of specific formats to override for example decoder or predicate. This is because they are contained in a nested :options hash-map being created here:

(wrapper h (assoc common-options :options (get format-options format)))

this does not override the top-level options via destructuring over here:
(let [{:keys [predicate decoder binary? options] :as options} (impl/extract-options args)]

Thus, the calls like (or predicate transit-json-request?) will always end up with the second expression and cannot be overriden.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants