Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(RouterStore): add DefaultRouterStateSerializer #1642

Closed
timdeschryver opened this issue Mar 20, 2019 · 2 comments · Fixed by #1900
Closed

Docs(RouterStore): add DefaultRouterStateSerializer #1642

timdeschryver opened this issue Mar 20, 2019 · 2 comments · Fixed by #1900
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs enhancement Project: Router Store
Projects
NgRx Docs

Comments

@timdeschryver
Copy link
Member

Add documentation for the default router serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializer.ts to ngrx.io.
This should be a page under Router Store

I would be willing to submit a PR for the docs ❤️

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
@timdeschryver timdeschryver changed the title Docs: add DefaultRouterStateSerializer Docs(RouterStore): add DefaultRouterStateSerializer Mar 20, 2019
@brandonroberts brandonroberts added this to To do in NgRx Docs Apr 11, 2019
@kanafghan
Copy link
Contributor

I can try to submit a PR for this.

@timdeschryver
Copy link
Member Author

👍 @kanafghan feel free to ping us when you some guidance

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label May 16, 2019
kanafghan added a commit to kanafghan/platform that referenced this issue May 18, 2019
@kanafghan
docs(router-store): add DefaultRouterStateSerializer
dc18f26 
Add documentation for the default router serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializer.ts to ngrx.io.

Closes ngrx#1642
@kanafghan kanafghan mentioned this issue May 18, 2019
Closed
3 tasks
@timdeschryver timdeschryver moved this from To do to In progress in NgRx Docs May 23, 2019
kanafghan added a commit to kanafghan/platform that referenced this issue May 23, 2019
@kanafghan
docs(router-store): add DefaultRouterStateSerializer
55a6aaa 
Add documentation for the default router serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializer.ts to ngrx.io.

Closes ngrx#1642
kanafghan added a commit to kanafghan/platform that referenced this issue May 30, 2019
@kanafghan
docs(router-store): add DefaultRouterStateSerializer
b0db437 
Add documentation for the default router serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializers/default_serializer.ts to ngrx.io.

Closes ngrx#1642
kanafghan added a commit to kanafghan/platform that referenced this issue May 30, 2019
@kanafghan
docs(router-store): add DefaultRouterStateSerializer
b8aeb7a 
Add documentation for the default router state serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializers/default_serializer.ts to ngrx.io.

Closes ngrx#1642
@kanafghan kanafghan mentioned this issue May 30, 2019
Merged
3 tasks
NgRx Docs automation moved this from In progress to Done Jun 4, 2019
brandonroberts pushed a commit that referenced this issue Jun 4, 2019
@kanafghan @brandonroberts
docs(router-store): add section for DefaultRouterStateSerializer to c…
11a9819 
…onfiguration guide (#1900)

Closes #1642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs enhancement Project: Router Store
Projects
NgRx Docs
  
Done
Milestone
No milestone
2 participants
@kanafghan @timdeschryver