docs(router-store): add DefaultRouterStateSerializer #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for the default router state serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializers/default_serializer.ts to ngrx.io. Closes ngrx#1642
|
Preview docs changes for b8aeb7a at https://previews.ngrx.io/pr1900-b8aeb7a/ |
brandonroberts
requested changes
May 31, 2019
| @@ -0,0 +1,3 @@ | |||
| # Default Router State Serializer | |||
There was a problem hiding this comment.
This doesn't need a separate file. I think it should go above Custom Router State Serializer in the configuration doc
There was a problem hiding this comment.
I agree with you @brandonroberts. I have done so based on the following sentence from @timdeschryver on #1642. If you guys agree, I will change it accordingly.
This should be a page under Router Store
|
Preview docs changes for a1c1ee6 at https://previews.ngrx.io/pr1900-a1c1ee6/ |
brandonroberts
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1642
What is the new behavior?
Add documentation for the default router state serializer - https://github.com/ngrx/platform/blob/master/modules/router-store/src/serializers/default_serializer.ts to ngrx.io.
Does this PR introduce a breaking change?
Other information